improvement: Allow auto-completed values to be recognized. Resolves #94 #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemDintecom
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
@EpicVoyage It would be nice to do this and test with the latest changes in master
|
I believe that the problem is not that we need to add a change listener. When a pre-filled value is selected, the only event fired is "input" - however on any browser other than android-chrome, the handle input function is not fired. The issue can be fixed on at least macos simply by removing the test for android-chrome. On a larger scale, I wonder why that check is there (unchanged for many years) and whether it is still necessary. |
|
I have a much simpler PR that I think addresses the root cause: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I manually tested this change with
npm startand Chrome browser autofill (#94).I have also generated a build via
npm run build:distfor inclusion in my project. This seems to be working well so far.