-
-
Notifications
You must be signed in to change notification settings - Fork 5
fix: A couple of documentation bugfixes and clarifications #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
guillemc23
wants to merge
124
commits into
nativescript-community:master
Choose a base branch
from
guillemc23:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Help users troubleshoot the zxing of undefined error via README
Add some information about the libraries used by this project.
Add documentation about libraries build upon
# Conflicts: # README.md
…p NativeScript version
Add Android scan sample, make embedded iOS sample conditional and bump NativeScript version
Added in the `npm install`
docs(Demo): Updated quick demo steps
During a `ns run ios` this message would appear: ``` warning: Directory /Users/adnan/play/tyltgo/packages/courier-app/node_modules/@nativescript-community/ui-bar codeview/platforms/ios/src with native iOS source code doesn't contain a modulemap file. Metadata for it will not be generated and it will not be accessible from JavaScript. To learn more see https://docs.nativescript.org/guides/ios-source-code ``` And in iOS, during runtime it showed this error: ``` Uncaught ReferenceError: QRCodeReader is not defined ``` This commit fixes the compile and runtime issue.
Add module.modulemap file for Objective-C code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.