Skip to content

[Mobile] Don't move DOM nodes #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2015
Merged

[Mobile] Don't move DOM nodes #219

merged 1 commit into from
Nov 5, 2015

Conversation

VWoeltjen
Copy link
Contributor

When including/excluding a DOM element via mct-device,
use replaceWith() instead of parent().append() to preserve
original ordering of DOM elements from template.
#213.

When including/excluding a DOM element via mct-device,
use replaceWith() instead of parent().append() to preserve
original ordering of DOM elements from template.
#213.
@VWoeltjen
Copy link
Contributor Author

Author Checklist

  1. Changes address original issue? Y
  2. Unit tests included and/or updated with changes? Y
  3. Command line build passes? Y
  4. Expect to pass code review? Y

@VWoeltjen VWoeltjen added this to the Ballard milestone Oct 28, 2015
@akhenry
Copy link
Contributor

akhenry commented Nov 5, 2015

Looks good to me.

Reviewer Checklist

  • Changes appear to address issue? Y
  • Appropriate unit tests included? Y
  • Code style and in-line documentation are appropriate? Y
  • Commit messages meet standards? Y

akhenry added a commit that referenced this pull request Nov 5, 2015
[Mobile] Don't move DOM nodes
@akhenry akhenry merged commit a356e01 into master Nov 5, 2015
@larkin larkin deleted the open213 branch May 3, 2016 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants