Skip to content

Conversation

@dangotbanned
Copy link
Member

@dangotbanned dangotbanned commented Apr 24, 2025

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@dangotbanned
Copy link
Member Author

dangotbanned commented Apr 24, 2025

I could always just revert the pandas changes in (3dd71a1), but I'm quite unsure how it broke plotly and wasn't caught by our tests πŸ€”

@FBruzzesi @MarcoGorelli - was wondering if you were able to spot anything semantically different?

Ideally so I could add a test that'll warn me when I do that again πŸ˜„

Update

No closer to knowing what was wrong, but whatever I introduced is no longer there (6d56dc6)

@dangotbanned dangotbanned changed the title chore(DRAFT): Add Version.dtypes, remove import_dtypes_module chore: Add Version.dtypes, remove import_dtypes_module Apr 24, 2025
@dangotbanned dangotbanned marked this pull request as ready for review April 24, 2025 18:23
Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dangotbanned - Left a tiny comment and maybe some thoughts for your comment

Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @dangotbanned

KemusanDogDanceGIF

@dangotbanned
Copy link
Member Author

LGTM Thanks @dangotbanned

KemusanDogDanceGIF KemusanDogDanceGIF

πŸ˜‚

@dangotbanned dangotbanned merged commit 1d5f830 into main Apr 25, 2025
30 checks passed
@dangotbanned dangotbanned deleted the version-props-dtypes branch April 25, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants