ci: Add RC release type for v2 release candidates #22362
+20
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
E2E Tests: n8n tests passed after 9m 24.5s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
cubic analysis
No issues found across 2 files
Linked issue analysis
Linked issue: CAT-1826: RC Release Type
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Can select "rc" in release workflow | Added rc option to release-create-pr.yml |
| ✅ | Creates 2.0.0-rc.0, then 2.0.0-rc.1, etc. | generateRcVersion creates -rc.0 and increments rc N |
| ✅ | Add rc to release-type options in release-create-pr.yml | rc added to the workflow options list |
| ✅ | Add generateRcVersion() function in bump-versions.mjs | New generateRcVersion function implemented |
| ✅ | Update RELEASE_TYPE regex to include rc | RELEASE_TYPE assertion updated to allow rc |
| ✅ | Add rc case in version bump logic | rc branch added to choose generateRcVersion |
| ✅ | Create new RC version when current version is non-rc (produces ..-rc.0) | generateRcVersion returns -rc.0 for non-prerelease versions |
| ✅ | Increment RC number when current version is already rc | Function detects 'rc' prerelease and increments numeric suffix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
rcrelease type option for creating v2 release candidates (2.0.0-rc.0, 2.0.0-rc.1, etc.).rcto release-type options inrelease-create-pr.ymlgenerateRcVersion()function inbump-versions.mjsrcRelated Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)