fix: allow named parameters to start with underscore - #59
Draft
harinarayansharma140 wants to merge 4 commits into
Draft
fix: allow named parameters to start with underscore#59harinarayansharma140 wants to merge 4 commits into
harinarayansharma140 wants to merge 4 commits into
Conversation
Updated RE_PARAM regex to support parameter names beginning with underscore (_), such as :_start, :_limit, :_offset, etc. Previously, the regex pattern [a-zA-Z][a-zA-Z0-9_]* required the first character to be a letter. This prevented valid parameter names like :_start from being recognized. Changed pattern to [a-zA-Z_][a-zA-Z0-9_]* to allow underscore as the first character, matching common SQL parameter naming conventions used by many database drivers and ORMs. This change maintains backward compatibility while extending support for a wider range of valid parameter names.
wellwelwel
changed the title
Member
wellwelwel
reviewed
Dec 23, 2025
| [123, 'admin'], | ||
| ]); | ||
|
|
||
| query = |
Member
There was a problem hiding this comment.
I believe that a test mixing one parameter that starts with _ and another that doesn't, is a good scenario to include in the tests to ensure that there are no conflicts when combining uses 🙋🏻♂️
wellwelwel
reviewed
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated RE_PARAM regex to support parameter names beginning with underscore (_), such as :_start, :_limit, :_offset, etc.
Previously, the regex pattern [a-zA-Z][a-zA-Z0-9_]* required the first character to be a letter. This prevented valid parameter names like :_start from being recognized.
Changed pattern to [a-zA-Z_][a-zA-Z0-9_]* to allow underscore as the first character, matching common SQL parameter naming conventions used by many database drivers and ORMs.
This change maintains backward compatibility while extending support for a wider range of valid parameter names.