Potential fix for code scanning alert no. 1: Arbitrary file access during archive extraction ("Zip Slip") #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring archive extraction ("Zip Slip")
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -80,7 +80,16 @@ | |||
| if (log.isLoggable(Level.FINER)) { | |||
| log.log(Level.FINER, "Jar entry: " + entry.getName()); | |||
| } | |||
| children.add(entry.getName()); | |||
| String entryName = entry.getName(); | |||
Check failure
Code scanning / CodeQL
Arbitrary file access during archive extraction ("Zip Slip") High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 month ago
To fix the issue, we need to ensure that the entry.getName() value is sanitized and validated before it is used in any file system operations or added to the children list. Specifically:
- Use
File.getCanonicalFile()to normalize the file path and ensure it does not escape the intended base directory. - Perform the validation check immediately after constructing the file path and before adding it to the
childrenlist or performing any other operations. - Log a warning and skip any entries that fail the validation.
The fix will involve modifying the code in the list method to ensure that all file paths derived from entry.getName() are properly validated.
Suggested changeset
1
src/main/java/org/apache/ibatis/migration/io/DefaultVFS.java
| @@ -91,3 +91,4 @@ | ||
| } | ||
| children.add(entryName); | ||
| // Add only the sanitized and validated entry name | ||
| children.add(entryFile.getName()); | ||
| } |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/mybatis/migrations/security/code-scanning/1
To fix the issue, we need to validate the
entry.getName()value to ensure it does not contain directory traversal sequences (../) or absolute paths. This can be achieved by normalizing the constructed path and verifying that it remains within the intended base directory. Specifically:java.nio.file.Pathto construct and normalize the path.The fix will be applied in the
listResourcesmethod (or equivalent logic) whereentry.getName()is processed.Suggested fixes powered by Copilot Autofix. Review carefully before merging.