Implement pause and select action (#17228) #28347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathesoncalum
force-pushed
the
17228-playback_pause_select
branch
from
83f2b29 to
3916f78
Compare
Contributor
|
Works great, thanks! Regarding the action name in Preferences, I think the word "current" is a bit confusing. Normally that means "the thing that is already selected". How about this instead?
I don't think it's necessary to say "playback" twice, as in:
|
mathesoncalum
force-pushed
the
17228-playback_pause_select
branch
from
3916f78 to
2ba67b6
Compare
mathesoncalum
force-pushed
the
17228-playback_pause_select
branch
from
2ba67b6 to
05b6c8f
Compare
mathesoncalum
force-pushed
the
17228-playback_pause_select
branch
from
05b6c8f to
3208c89
Compare
mathesoncalum
force-pushed
the
17228-playback_pause_select
branch
2 times, most recently
from
6ba5e9c to
2790dac
Compare
mathesoncalum
force-pushed
the
17228-playback_pause_select
branch
from
2790dac to
a27f057
Compare
RomanPudashkin
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #17228
This PR implements a shortcutable "pause and select" action. By default this is set to
Ctrl+Spacefor Windows/Linux,Alt+Spacefor MacOS. The action will select the currentChordRestin the last selected stave (or the top stave if nothing was selected).