Skip to content

Conversation

@XiaoMigros
Copy link
Contributor

Resolves: #27346

Works for entering edit mode with keyboard shortcuts as well as 'Edit element' from the context menu.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@cbjeukendrup cbjeukendrup self-requested a review June 9, 2025 18:15
@XiaoMigros XiaoMigros force-pushed the select-text-on-edit branch from f18b94a to 5b4fe88 Compare June 9, 2025 18:27
@cbjeukendrup cbjeukendrup removed their request for review June 17, 2025 13:32
@cbjeukendrup
Copy link
Member

@XiaoMigros could you please look into the unit test failure?

@XiaoMigros XiaoMigros force-pushed the select-text-on-edit branch from 5b4fe88 to aa56e74 Compare July 9, 2025 21:23
@XiaoMigros XiaoMigros marked this pull request as draft September 1, 2025 05:43
@cbjeukendrup
Copy link
Member

@XiaoMigros would you mind rebasing this so that it can be tested?

@cbjeukendrup
Copy link
Member

@XiaoMigros We would like to test and merge this PR, could you please look into the test failures?

@avvvvve
Copy link

avvvvve commented Oct 30, 2025

This looks good to me! @DmitryArefiev if you don't mind QAing this too once the test failures are resolved that'd be great.

@avvvvve avvvvve requested a review from DmitryArefiev October 30, 2025 22:00
@cbjeukendrup
Copy link
Member

Let's wait for a rebase / test fix first, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When starting to edit a text element via keyboard, select the entire contents

3 participants