[Experiment] Testing codemod behavior#7728
Closed
alexfauquette wants to merge 1 commit intomui:masterfrom
Closed
Conversation
These are the results for the performance tests:
|
| @@ -0,0 +1,9 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Hey @alexfauquette, do you have any examples of how your pickers change between versions? Maybe a diff? I can see if I can quickly mock something up for you 😊
Member
Author
There was a problem hiding this comment.
Most of the modifications have already been done:
- pickers [pickers] Add codemods for breaking changes #6997
- data grid [DataGrid] Add codemods for v6 breaking changes #7086
The modification I proposed in codeshift comunity comes from migrate-to-components-componentsProps
which work well with self-closing elements
But I realized it was a problem when adding the transformation to our preset-safe
That's why I'm proposing to add a filtering condition on the parent
componentNames.includes(attributeParent.value.name.name)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experience made to discuss in hypermod-io/hypermod-community#141