[code-infra] Add plugin to check for index file access #46178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
added
the
scope: code-infra
Netlify deploy previewhttps://deploy-preview-46178--material-ui.netlify.app/ Bundle size report |
Member
|
Haven't reviewed the code yet, but should this be in public? We might benefit from it in X as well |
Member
Author
|
We will move all eslint config into mui-public eventually. I didn't create a full plugin, just added a rule to the existing material ui plugin. you'll be able to use this in X. |
Member
Derp, I missed that totally 😆 |
JCQuintas
approved these changes
May 28, 2025
Comment on lines
66
to
70
| const regexPattern = new RegExp( | ||
| pattern | ||
| .replace(/[.*+?^${}()|[\]\\]/g, '\\$&') // Escape special regex chars except * | ||
| .replace(/\*/g, '.*'), // Convert * to .* for wildcard matching | ||
| ); |
Member
There was a problem hiding this comment.
This is a bit sketchy, don't we have a glob util we can use?
Member
Author
There was a problem hiding this comment.
eslint uses minimatch, I'll do the same
JCQuintas
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard against #46177
Created a custom plugin that works similar to the
no-unresolved-imports, but that looks at the resolved specifier.