Skip to content

fix: Add warning when password is set without username #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

adam-abdelrahman0
Copy link

Ref #1685

This change implements a warning if a password is provided without a username in an IClientOptions object in the connect() function.

  • index.ts: add condition after parseAuthOptions() to warn if no username has been set.

@adam-abdelrahman0 adam-abdelrahman0 changed the title Add warning when password is set without username (fix)Add warning when password is set without username Apr 30, 2025
@adam-abdelrahman0 adam-abdelrahman0 changed the title (fix)Add warning when password is set without username fix: Add warning when password is set without username Apr 30, 2025
@robertsLando
Copy link
Member

@adam-abdelrahman0 there is no specification that explains this, I mean someone could have users with empty username for whatever reason, cannot accept this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants