Implement multiple tiers caching with fallback and backfilling#2581
Implement multiple tiers caching with fallback and backfilling#2581Felixoid wants to merge 17 commits intomozilla:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2581 +/- ##
==========================================
+ Coverage 73.38% 74.18% +0.80%
==========================================
Files 68 70 +2
Lines 37338 39206 +1868
==========================================
+ Hits 27400 29085 +1685
- Misses 9938 10121 +183 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0a4503d to
e069c90
Compare
38af4ef to
b70bd73
Compare
22b9835 to
445e8b9
Compare
7e50b5c to
3b5cfe5
Compare
|
I've done quite a few features today, like control for write error handling, and added server stats for multilevel caching. |
|
this is a huge patch, can you split a bit more? thanks |
|
Probably I could take something out of |
3fe062e to
1dc75d4
Compare
|
Rebased to the current This PR now contains the multi-level cache feature exclusively. Most of the changes are the tests and documentation, which are around 70%. |
|
In general, I like that changes. There's awesome work, thanks, @Felixoid! JFYI, you have a failed CUDA test. Please, recheck this point too. |
|
Thanks a lot for the review! @AJIOB: it looks like the CUDA tests were temporarily broken for an unknown reason. It was @mathstuf: as much as I like the idea, it looks like a next iteration for now. Probably, I'd like to work on it too. But it's for sure will be a design change for the configuration, and should be discussed in advance on how to proceed. Now, the approach is simple and logical for the current configuration. |
|
@sylvestre do you think we can proceed? |
There was a problem hiding this comment.
Bar the shell scripts, the core implementation does look sound. Also took a look @trxcllnt which is a more minimal approach with 2 cache layers (or using nesting).
Since this PR already got reviews I suggest to move it along.
@sylvestre if you find the time, take a look, otherwise I'll do sometime next week and we should land it imho.
|
Thanks for the review! I am on vacation RN, will try to find time to address the points somewhere around the following week. |
8214af5 to
43089ab
Compare
|
@drahnr I addressed all points. Sorry that it took so long. I tried not to touch the laptop for work |
|
In case #2644 is merged, this PR should benefit too; there are around 50 lines of boilerplate. |
|
Any update on the process, please? |
|
Hi @drahnr and @sylvestre , Is it OK for you? Can we merge these changes? |
|
Thanks a lot for the work here, just curious if SCCACHE_BASEDIRS is handled properly when using the multi-tier setup? |
|
i am not ignoring you. just higher priorities lately, sorry |
I don't have any specific tests for it, but I don't see how it could break. I'll try to add it too, just in case |
|
@sunnyguan thanks a lot for the spotlight, I indeed forgot to implement the |
fe2c7fa to
f590fb8
Compare
This PR addresses multiple requests to have tiered caching.
Closes #30
Closes #1020
Closes #2493
Closes #2566
What is added: