Skip to content

Fix: handle JSON-LD @type as array in _getJSONLD #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JSap0914 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: handle JSON-LD @type as array in _getJSONLD #1013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions Readability.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1659,6 +1659,17 @@ Readability.prototype = {
var scripts = this._getAllNodesWithTag(doc, ["script"]);

var metadata;
var self = this;

// @type can be a string or an array of strings per the JSON-LD spec.
function matchesArticleType(type) {
var types = Array.isArray(type) ? type : [type].filter(Boolean);
return types.some(function (t) {
return (
typeof t === "string" && !!t.match(self.REGEXPS.jsonLdArticleTypes)
Comment on lines +1666 to +1669

@gijsk gijsk Jul 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem like we need both .filter here and then a typeof check below - can we drop the filter?

);
});
}

this._forEachNode(scripts, function (jsonLdElement) {
if (
Expand All @@ -1675,10 +1686,7 @@ Readability.prototype = {

if (Array.isArray(parsed)) {
parsed = parsed.find(it => {
return (
it["@type"] &&
it["@type"].match(this.REGEXPS.jsonLdArticleTypes)
);
return matchesArticleType(it["@type"]);
});
if (!parsed) {
return;
Expand All @@ -1699,14 +1707,14 @@ Readability.prototype = {

if (!parsed["@type"] && Array.isArray(parsed["@graph"])) {
parsed = parsed["@graph"].find(it => {
return (it["@type"] || "").match(this.REGEXPS.jsonLdArticleTypes);
return matchesArticleType(it["@type"]);
});
}

if (
!parsed ||
!parsed["@type"] ||
!parsed["@type"].match(this.REGEXPS.jsonLdArticleTypes)
!matchesArticleType(parsed["@type"])
) {
return;
}
Expand Down
9 changes: 9 additions & 0 deletions test/test-pages/jsonld-array-type/expected-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"title": "Array Type Test Article",
"byline": "Test Author",
"dir": null,
"excerpt": "A test article whose JSON-LD @type is an array rather than a plain string.",
"siteName": "Example Publisher",
"publishedTime": "2024-06-01",
"readerable": true
}
22 changes: 22 additions & 0 deletions test/test-pages/jsonld-array-type/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<div id="readability-page-1" class="page"><article>

<p>
The JSON-LD specification allows the <code>@type</code> property to be
either a single string (<code>"NewsArticle"</code>) or an array of strings
(<code>["NewsArticle", "Article"]</code>). Readability must correctly
extract metadata in both cases.
</p>
<p>
This page tests that when <code>@type</code> is an array, Readability
still reads the article title, byline, excerpt, site name, and
published time from the JSON-LD block. Without the fix, Readability
silently discards the entire JSON-LD object and returns <code>null</code>
for all metadata fields.
</p>
<p>
The root cause is that <code>Array.prototype.match</code> does not exist,
so calling <code>type.match(regex)</code> on an array throws a
<code>TypeError</code> that the existing try/catch swallows, leaving the
metadata object unpopulated.
</p>
</article></div>
49 changes: 49 additions & 0 deletions test/test-pages/jsonld-array-type/source.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8"/>
<title>Array Type Test Article | Example Site</title>
<script type="application/ld+json">
{
"@context": "https://schema.org",
"@type": ["NewsArticle", "Article"],
"name": "Array Type Test Article",
"headline": "Array Type Test Article",
"description": "A test article whose JSON-LD @type is an array rather than a plain string.",
"datePublished": "2024-06-01",
"author": {
"@type": "Person",
"name": "Test Author"
},
"publisher": {
"@type": "Organization",
"name": "Example Publisher"
}
}
</script>
</head>
<body>
<article>
<h1>Array Type Test Article</h1>
<p>
The JSON-LD specification allows the <code>@type</code> property to be
either a single string (<code>"NewsArticle"</code>) or an array of strings
(<code>["NewsArticle", "Article"]</code>). Readability must correctly
extract metadata in both cases.
</p>
<p>
This page tests that when <code>@type</code> is an array, Readability
still reads the article title, byline, excerpt, site name, and
published time from the JSON-LD block. Without the fix, Readability
silently discards the entire JSON-LD object and returns <code>null</code>
for all metadata fields.
</p>
<p>
The root cause is that <code>Array.prototype.match</code> does not exist,
so calling <code>type.match(regex)</code> on an array throws a
<code>TypeError</code> that the existing try/catch swallows, leaving the
metadata object unpopulated.
</p>
</article>
</body>
</html>