VPN-7450: Consider Android nav style when creating drawer height#11124
Merged
VPN-7450: Consider Android nav style when creating drawer height#11124
Conversation
artfwo
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We didn't consider bottom padding appropriately. I don't know for sure if this is a Qt 6.10 thing or not. I spent a while (possibly too long) trying to make this work with SafeArea insets, and ultimately couldn't make it work. This seems like a sledgehammer, but it works.
Claude helped a bunch with this code. Along the journey, Claude also gave many wrong answers, and let me astray quite a bit.
Reference
VPN-7450
Checklist