[FXIOS-15029, 15036] Fix Autofill JS email focus callback for some website regsitration forms

[mattreaganmozilla]

📜 Tickets

Jira ticket

💡 Description

@issammani I am not well-versed with our Autofill JS, but the issue seems to be that we have some login-specific checks that are interfering on some email registration forms.

The changes here:

• Skip the early return for isLoginField if the focused field appears to be email
• Avoids dropping into the username/password conditional if we can see the field looks like an email field

These changes fix the bug in the problematic sites I've tested so far, but I'd love some extra eyes on this, since I'm not a Javascript expert and I don't have much context on some of the logic for our Autofill code. I want to make sure that there isn't a risk of regressing or causing issues with other Autofill behaviors for e.g. standard login forms.

📝 Checklist

• I filled in the ticket numbers and a description of my work
• I updated the PR name to follow our PR naming guidelines
• I ensured unit tests pass and wrote tests for new code
• If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
• If adding telemetry, I read the data stewardship requirements and will request a data review
• If adding or modifying strings, I read the guidelines and will request a string review from l10n
• If needed, I updated documentation and added comments to complex code

[mobiletest-ci-bot]

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

💬 Description craftsman

Great PR description! Reviewers salute you 🫡

✅ New file code coverage

No new file detected so code coverage gate wasn't ran.

Generated by 🚫 Danger Swift against a898e6a