Skip to content

Refactor RMST-296 [Remote-Settings] Renaming RemoteSettingsConfig2 to match updated application-services code#32242

Open
alexcottner wants to merge 1 commit intomozilla-mobile:mainfrom
alexcottner:rs-config-rename
Open

Refactor RMST-296 [Remote-Settings] Renaming RemoteSettingsConfig2 to match updated application-services code#32242
alexcottner wants to merge 1 commit intomozilla-mobile:mainfrom
alexcottner:rs-config-rename

Conversation

@alexcottner
Copy link

📜 Tickets

Jira ticket
Bugzilla

💡 Description

Application-Services PR 7186 is removing the legacy remote-settings rust client. In the process, this is renaming the RemoteSettingsConfig2 struct to RemoteSettingsConfig.

Once this PR is landed, we will break builds. This PR will need to be landed and the generated wrappers under MozillaRustComponents/Sources/ will need to be regenerated.

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
    • This PR, along with regenerating the swift wrappers, will fix broken builds once 7186 lands

Copy link
Collaborator

@issammani issammani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexcottner. This looks good 🔥 . As discussed in slack, let's hold off on merging the AS PR until Thursday. That way we get the bump on iOS Friday early morning and we can merge this with the bump PR after we cut the new release

@issammani issammani added the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Feb 24, 2026
@lmarceau lmarceau removed their request for review February 24, 2026 15:22
@alexcottner
Copy link
Author

mozilla/application-services#7186 has been merged, you should be able to merge this tomorrow

@issammani
Copy link
Collaborator

issammani commented Mar 2, 2026

mozilla/application-services#7186 has been merged, you should be able to merge this tomorrow

We will need a new AS binary. That will happen tomorrow at 8am UTC. I will trigger CI and merge it then 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge ⛔️ This issue is a work in progress and is not ready to land

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants