Skip to content
This repository was archived by the owner on Nov 12, 2017. It is now read-only.

Add Scheduler#1

Open
briancavalier wants to merge 1 commit intomasterfrom
add-scheduler
Open

Add Scheduler#1
briancavalier wants to merge 1 commit intomasterfrom
add-scheduler

Conversation

@briancavalier
Copy link
Member

Add Scheduler, convert to ES6, and extract ScheduledTask and binarySearch to allow them to be tested. It's possible more things could be extracted, and/or Scheduler broken down further (that's likely outside the scope of this PR).

Open questions

  1. Is this even the right place for Scheduler to live? Another alternative is for it to live in its own package, i.e. @most/scheduler.
  2. Should nodeTimer and timeoutTimer live here also?

Todo

  • decide where Scheduler should live
  • unit tests

@TylorS
Copy link
Member

TylorS commented Apr 7, 2016

Initially I feel it might be better for something like @most/scheduler but then part of me thinks about how many repos we are and will be accumulating.

My gut feeling is that nodeTimer and timeoutTimer should live with the Scheduler, wherever Scheduler does end up.

@briancavalier
Copy link
Member Author

Yeah, I'm having the same struggle with package granularity, @TylorS.

Here's an idea: what if, instead of starting at the "bottom", i.e. @most/stream, @most/scheduler, etc. we start at the "top", and create @most/core first. It could initially include everything we've talked about having in @most/stream, @most/scheduler, and @most/core. After we create that (or in the process of creating it), maybe we'll get a better feel for the right granularity without running the risk of creating "too many" packages initially.

Thoughts?

@TylorS
Copy link
Member

TylorS commented Apr 7, 2016

@briancavalier That seems like a rather pragmatic approach 👍

@briancavalier
Copy link
Member Author

Ok, cool. I'll just rename this repo and update package.json :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants