You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 12, 2017. It is now read-only.
Add Scheduler, convert to ES6, and extract ScheduledTask and binarySearch to allow them to be tested. It's possible more things could be extracted, and/or Scheduler broken down further (that's likely outside the scope of this PR).
Open questions
Is this even the right place for Scheduler to live? Another alternative is for it to live in its own package, i.e. @most/scheduler.
Initially I feel it might be better for something like @most/scheduler but then part of me thinks about how many repos we are and will be accumulating.
My gut feeling is that nodeTimer and timeoutTimer should live with the Scheduler, wherever Scheduler does end up.
Yeah, I'm having the same struggle with package granularity, @TylorS.
Here's an idea: what if, instead of starting at the "bottom", i.e. @most/stream, @most/scheduler, etc. we start at the "top", and create @most/corefirst. It could initially include everything we've talked about having in @most/stream, @most/scheduler, and @most/core. After we create that (or in the process of creating it), maybe we'll get a better feel for the right granularity without running the risk of creating "too many" packages initially.
Ok, cool. I'll just rename this repo and update package.json :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Scheduler, convert to ES6, and extract ScheduledTask and binarySearch to allow them to be tested. It's possible more things could be extracted, and/or Scheduler broken down further (that's likely outside the scope of this PR).
Open questions
@most/scheduler.Todo