Skip to content

Conversation

@zhenyu-ms
Copy link
Contributor

Bug / Requirement Description

certain python package will block signals, which will be inherited by subprocess in App driver, which will later cause SIGTERM failed to be received by subprocess

Solution description

unblock all signals in subprocess.Popen's preexec_fn

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

@zhenyu-ms zhenyu-ms requested a review from a team as a code owner October 24, 2024 03:26
@zhenyu-ms zhenyu-ms changed the title Fix/unmask all signals in App driver's subprocess Misc/capture logs when running examples Oct 25, 2024
@zhenyu-ms zhenyu-ms merged commit cf9034b into morganstanley:main Oct 25, 2024
15 checks passed
@zhenyu-ms zhenyu-ms deleted the unmask-sig branch October 25, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants