Skip to content

Limit line length in commit message body to 72 characters #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ziegenberg
Copy link
Contributor

Following a discussion in Moodle Dev chat and the recommendation from the Commit cheat sheet the commit message body should wrap at 72 and not at 132 characters.

Following a discussion in Moodle Dev chat and the recommendation from
the Commit cheat sheet the commit message body should wrap at 72 and
not at 132 characters.

Signed-off-by: Daniel Ziegenberg <[email protected]>
@ziegenberg ziegenberg force-pushed the commit-message-length-72 branch from fa03670 to d2dc4f4 Compare March 21, 2025 14:33
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.42%. Comparing base (9e3dfd2) to head (d2dc4f4).

Files with missing lines Patch % Lines
verify_commit_messages/verify_commit_messages.sh 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
- Coverage   31.75%   29.42%   -2.33%     
==========================================
  Files          71       71              
  Lines        3222     3222              
==========================================
- Hits         1023      948      -75     
- Misses       2199     2274      +75     
Flag Coverage Δ
check_upgrade_savepoints 0.46% <0.00%> (ø)
checkstyle_manipulations 0.00% <0.00%> (ø)
compare_databases 2.38% <0.00%> (ø)
continuous_manage_queues_validation 0.71% <0.00%> (ø)
define_excluded 1.11% <0.00%> (ø)
detect_conflicts 1.48% <0.00%> (ø)
diff_extract_changes 0.00% <0.00%> (ø)
git_sync_two_branches ?
grunt_process 3.01% <0.00%> (ø)
illegal_whitespace 2.63% <0.00%> (ø)
list_valid_components 0.00% <0.00%> (ø)
mustache_lint 2.82% <0.00%> (ø)
mustache_lint_plugins 1.30% <0.00%> (ø)
php_lint 1.21% <0.00%> (ø)
prepare_npm_stuff 1.52% <0.00%> (ø)
remote_branch_checker 17.44% <50.00%> (+0.06%) ⬆️
remote_branch_reporter 0.00% <0.00%> (ø)
setup 0.00% <0.00%> (ø)
thirdparty_check 1.45% <0.00%> (ø)
travis-branch-checker 0.00% <0.00%> (ø)
upgrade_external_backup 1.61% <0.00%> (ø)
verifications 0.00% <0.00%> (ø)
verify_commit_messages ?
versions_check_set 5.02% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants