MONGOID-5899 Write conflict error when accessing embedded documents via [] operator after direct DB update #6077
+19
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ia [] operator after direct DB update (mongodb#6076) * Adds support for single hash input in nested attributes for has_many associations. * Fixing write conflict error when using [] to access embedded document * undoing accidental changes
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports MONGOID-5899, which fixes a conflicting update error when accessing embedded documents using the attribute accessor ([] notation). The fix prevents incorrectly marking embedded relations as changed when accessed via bracket notation.
Key Changes:
- Modified
process_raw_attributeto check if an attribute is a relation before marking it as changed - Added test coverage for accessing embedded documents with the attribute accessor to ensure no conflicting update errors occur
- Fixed a typo in an existing test context name ("modifiying" → "modifying")
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/mongoid/attributes.rb | Added relation check to prevent marking embedded relations as changed when accessed |
| spec/mongoid/attributes_spec.rb | Added test case for embedded document access and corrected spelling in context name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jamis
approved these changes
Dec 18, 2025
kyleburgess2025
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of MONGOID-5899