Skip to content

CLOUDP-314916: e2e OIDC multicluster tests #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 120 commits into from
Jun 5, 2025

Conversation

anandsyncs
Copy link
Contributor

@anandsyncs anandsyncs commented May 22, 2025

Summary

This pull request adds new (E2E) tests for multi-cluster OIDC M2M authentication scenarios:

  • New test cases covering multi-cluster OIDC M2M group and user authentication workflows.
  • Supporting YAML fixtures for configuring and testing OIDC in multi-cluster environments.
  • Updates to existing sharded-cluster OIDC test logic to support multi-cluster tests.

Proof of Work

Passing e2e tests.

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Our Short Guide for PRs: Link
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

MaciejKaras and others added 30 commits April 27, 2025 13:35
…-crd-propagation

# Conflicts:
#	controllers/operator/authentication/authentication_mechanism.go
@anandsyncs anandsyncs changed the base branch from master to anandsingh/oidc-e2e-tests May 27, 2025 08:00
@anandsyncs
Copy link
Contributor Author

evergreen patch

@anandsyncs anandsyncs changed the base branch from anandsingh/oidc-e2e-tests to master May 27, 2025 17:14
@anandsyncs
Copy link
Contributor Author

evergreen retry

@anandsyncs anandsyncs changed the base branch from master to anandsingh/oidc-e2e-tests May 28, 2025 09:38
Base automatically changed from anandsingh/oidc-e2e-tests to master June 3, 2025 07:52
@MaciejKaras MaciejKaras marked this pull request as ready for review June 3, 2025 13:17
@MaciejKaras MaciejKaras requested a review from Copilot June 3, 2025 13:20
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds end-to-end tests and fixtures to validate multi-cluster OIDC machine-to-machine authentication, updates sharded-cluster tests for multi-cluster support, and integrates new test tasks into Evergreen CI.

  • New E2E test modules for multi-cluster OIDC user and group workflows
  • Supporting YAML fixtures for multi-cluster OIDC scenarios
  • Sharded-cluster test updates: multi-cluster logic, service name handling, and increased timeouts
  • CI configuration (.evergreen.yml & .evergreen-tasks.yml) updated to run the new tests

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
docs/mongodbcommunity/users.md Removed stray blank line
docker/mongodb-kubernetes-tests/tests/multicluster/multi_cluster_oidc_m2m_user.py Added multi-cluster OIDC M2M user tests
docker/mongodb-kubernetes-tests/tests/multicluster/multi_cluster_oidc_m2m_group.py Added multi-cluster OIDC M2M group tests
docker/mongodb-kubernetes-tests/tests/multicluster/fixtures/oidc/oidc-user-multi.yaml New fixture for OIDC M2M user
docker/mongodb-kubernetes-tests/tests/multicluster/fixtures/oidc/mongodb-multi-m2m-user.yaml New multi-cluster MongoDBMultiCluster fixture for user tests
docker/mongodb-kubernetes-tests/tests/multicluster/fixtures/oidc/mongodb-multi-m2m-group.yaml New multi-cluster MongoDBMultiCluster fixture for group tests
docker/mongodb-kubernetes-tests/tests/authentication/sharded_cluster_oidc_m2m_user.py Updated sharded-cluster OIDC user tests for multi-cluster adaptations
docker/mongodb-kubernetes-tests/tests/authentication/sharded_cluster_oidc_m2m_group.py Updated sharded-cluster OIDC group tests with multi-cluster logic
.evergreen.yml Added new E2E test tasks to CI task group
.evergreen-tasks.yml Registered new E2E test tasks
Comments suppressed due to low confidence (1)

docker/mongodb-kubernetes-tests/tests/authentication/sharded_cluster_oidc_m2m_group.py:93

  • The skip_if_multi_cluster decorator should be referenced without parentheses (i.e. @skip_if_multi_cluster) to avoid calling the function at import time.
@skip_if_multi_cluster()

Copy link
Collaborator

@Julien-Ben Julien-Ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool that you made hybrid tests, working in both single and multi cluster variants !

@anandsyncs anandsyncs enabled auto-merge (squash) June 5, 2025 20:02
@anandsyncs anandsyncs disabled auto-merge June 5, 2025 20:05
@anandsyncs anandsyncs merged commit 7a73bf1 into master Jun 5, 2025
8 of 10 checks passed
@anandsyncs anandsyncs deleted the anandsingh/e2e-oidc-multicluster branch June 5, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants