Skip to content

DOCSP-46749 Duplicate Title Java RS #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 25, 2025

Conversation

shuangela
Copy link
Collaborator

@shuangela shuangela commented Feb 24, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-46749
Staging - https://deploy-preview-98--docs-java-rs.netlify.app/get-started/run-sample-query/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Do we want to change the URL as well of the connect-to-mongodb page? I was leaning towards no, because I saw in our TOC doc that we're planning on consolidating all the get started subpages into one long get started page, but I'm open to suggestions!

Sorry, something went wrong.

Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for docs-java-rs ready!

Name Link
🔨 Latest commit ee37614
🔍 Latest deploy log https://app.netlify.com/sites/docs-java-rs/deploys/67be2b75f470160008b035e6
😎 Deploy Preview https://deploy-preview-98--docs-java-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shuangela shuangela changed the title change title to avoid duplicates DOCSP-46749 Duplicate Title Java RS Feb 24, 2025
Copy link
Collaborator

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great name change! We haven't received guidance about changing the URLs. Can you message @sarahemlin about the URL question and send her this PR? I'll approve this PR once you hear back.

@sarahemlin
Copy link
Collaborator

@lindseymoore & @shuangela, in this case, the new title is so different from the old one that I think we should update the URL.

Copy link
Collaborator

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to make sure page shows up in TOC!

Copy link
Collaborator

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! Please backport to relevant versions, and let me know if you have any questions!

@shuangela shuangela merged commit 4da7d33 into mongodb:main Feb 25, 2025
11 checks passed
Copy link

The backport to v5.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v5.2 v5.2
# Navigate to the new working tree
cd .worktrees/backport-v5.2
# Create a new branch
git switch --create backport-98-to-v5.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4da7d33d932819fd56df5d95fdfc962f38964437
# Push it to GitHub
git push --set-upstream origin backport-98-to-v5.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v5.2

Then, create a pull request where the base branch is v5.2 and the compare/head branch is backport-98-to-v5.2.

github-actions bot pushed a commit that referenced this pull request Feb 25, 2025
change duplicate title

(cherry picked from commit 4da7d33)
shuangela added a commit to shuangela/docs-java-rs that referenced this pull request Feb 25, 2025
change duplicate title

(cherry picked from commit 4da7d33)
shuangela added a commit that referenced this pull request Feb 25, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants