-
Notifications
You must be signed in to change notification settings - Fork 17
DOCSP-46749 Duplicate Title Java RS #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-46749 Duplicate Title Java RS #98
Conversation
✅ Deploy Preview for docs-java-rs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great name change! We haven't received guidance about changing the URLs. Can you message @sarahemlin about the URL question and send her this PR? I'll approve this PR once you hear back.
@lindseymoore & @shuangela, in this case, the new title is so different from the old one that I think we should update the URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to make sure page shows up in TOC!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM! Please backport to relevant versions, and let me know if you have any questions!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v5.2 v5.2
# Navigate to the new working tree
cd .worktrees/backport-v5.2
# Create a new branch
git switch --create backport-98-to-v5.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4da7d33d932819fd56df5d95fdfc962f38964437
# Push it to GitHub
git push --set-upstream origin backport-98-to-v5.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v5.2 Then, create a pull request where the |
change duplicate title (cherry picked from commit 4da7d33)
change duplicate title (cherry picked from commit 4da7d33)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-46749
Staging - https://deploy-preview-98--docs-java-rs.netlify.app/get-started/run-sample-query/
Self-Review Checklist
Do we want to change the URL as well of the connect-to-mongodb page? I was leaning towards no, because I saw in our TOC doc that we're planning on consolidating all the get started subpages into one long get started page, but I'm open to suggestions!