DOCSP-42300: Standardize Monitoring page #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-java-rs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stephmarie17
approved these changes
Aug 27, 2024
source/monitoring.txt
Outdated
| .. tip:: Consult the Official JMX and JConsole Documentation | ||
|
|
||
| The descriptions of JMX and JConsole in this example are illustrative | ||
| rather than a source of truth. For guaranteed up to date information, consult |
There was a problem hiding this comment.
Suggested change
| rather than a source of truth. For guaranteed up to date information, consult | |
| rather than a source of truth. For guaranteed up-to-date information, consult |
source/monitoring.txt
Outdated
| Once JConsole is open, perform the following actions in the GUI: | ||
|
|
||
| #. Select the Java process running the preceding example code. | ||
| #. Press :guilabel:`Insecure Connection` in the warning dialog box. |
There was a problem hiding this comment.
[s] In the style guide, it sounds like press is reserved for a specific key on a keyboard, but not super familiar with JConsole so possibly that is a better choice so might not need to update:
Suggested change
| #. Press :guilabel:`Insecure Connection` in the warning dialog box. | |
| #. Click :guilabel:`Insecure Connection` in the warning dialog box. |
source/monitoring.txt
Outdated
Comment on lines
369
to
370
| When you no longer want to inspect your connection pools in JConsole, do the | ||
| following: |
There was a problem hiding this comment.
[s] To better align with the introducing lists section of the style guide:
Suggested change
| When you no longer want to inspect your connection pools in JConsole, do the | |
| following: | |
| When you no longer want to inspect your connection pools in JConsole, perform the | |
| following tasks: |
source/monitoring.txt
Outdated
Comment on lines
372
to
373
| - Exit JConsole by closing the JConsole window | ||
| - Stop the Java program running the preceding code snippet |
There was a problem hiding this comment.
[q] Do these need to be completed in order or it doesn't matter? Also I think can use punctuation as imperative statements.
Suggested change
| - Exit JConsole by closing the JConsole window | |
| - Stop the Java program running the preceding code snippet | |
| - Exit JConsole by closing the JConsole window. | |
| - Stop the Java program running the preceding code snippet. |
mcmorisi
requested review from
a team and
vbabanin
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-42300
Staging - https://preview-mongodbmcmorisi.gatsbyjs.io/java-rs/DOCSP-42300-monitoring/monitoring/
Self-Review Checklist