Skip to content

DOCSP-42295: Upgrade Driver Versions #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Aug 26, 2024

I ended up poaching this one pretty much wholesale from the Java Sync version. Scanned through everything and it seems to be largely core-level API changes.

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-42295
Staging - https://preview-mongodbmcmorisi.gatsbyjs.io/java-rs/DOCSP-42295-upgrade/upgrade/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Sorry, something went wrong.

fix
Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for docs-java-rs ready!

Name Link
🔨 Latest commit 4f47611
🔍 Latest deploy log https://app.netlify.com/sites/docs-java-rs/deploys/66cde6877d8eec00089f151c
😎 Deploy Preview https://deploy-preview-81--docs-java-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Fix
Copy link
Collaborator

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines 30 to 31
application runs on. See the :ref:`Java Compatibility <java-rs-compatibility>`
page for this information.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: to avoid confusion since I originally thought this was linking to the Java sync driver page

Suggested change
application runs on. See the :ref:`Java Compatibility <java-rs-compatibility>`
page for this information.
application runs on. See the :ref:`Compatibility page<java-rs-compatibility>`
for this information.

@mcmorisi mcmorisi requested review from a team and rozza and removed request for a team August 27, 2024 14:45
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcmorisi mcmorisi merged commit cba57be into mongodb:main Aug 29, 2024
5 checks passed
@mcmorisi mcmorisi deleted the DOCSP-42295-upgrade branch August 29, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants