DOCSP-42297: Time Series #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-java-rs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jordan-smith721
approved these changes
Aug 21, 2024
Collaborator
jordan-smith721
left a comment
jordan-smith721
left a comment
There was a problem hiding this comment.
Nice work! A couple suggestions but otherwise LGTM
| :backlinks: none | ||
| :depth: 1 | ||
| :class: singlecol | ||
|
|
Collaborator
There was a problem hiding this comment.
Add facets/meta tags
source/data-formats/time-series.txt
Outdated
Comment on lines
66
to
67
| object with the `TimeSeriesOptions <{+api+}/mongodb-driver-core/com/mongodb/client/model/TimeSeriesOptions.html>`__ set | ||
| using the ``timeSeriesOptions()`` method |
Collaborator
There was a problem hiding this comment.
S: to avoid "using"
Suggested change
| object with the `TimeSeriesOptions <{+api+}/mongodb-driver-core/com/mongodb/client/model/TimeSeriesOptions.html>`__ set | |
| using the ``timeSeriesOptions()`` method | |
| object with the `TimeSeriesOptions <{+api+}/mongodb-driver-core/com/mongodb/client/model/TimeSeriesOptions.html>`__ specified in the ``timeSeriesOptions()`` method |
source/data-formats/time-series.txt
Outdated
| Example | ||
| ~~~~~~~ | ||
|
|
||
| This example creates the ``october2024`` time series collection in the |
Collaborator
There was a problem hiding this comment.
Suggested change
| This example creates the ``october2024`` time series collection in the | |
| The following example creates a time series collection named ``october2024`` in the |
Comment on lines
+114
to
+115
| Example | ||
| ~~~~~~~ |
Collaborator
There was a problem hiding this comment.
I don't think this header is needed here
source/data-formats/time-series.txt
Outdated
| Example | ||
| ~~~~~~~ | ||
|
|
||
| This example inserts New York City temperature data into the ``october2024`` |
Collaborator
There was a problem hiding this comment.
Suggested change
| This example inserts New York City temperature data into the ``october2024`` | |
| The following example inserts New York City temperature data into the ``october2024`` |
mcmorisi
requested review from
a team and
vbabanin
and removed request for
a team
Collaborator
Author
|
@vbabanin Bumping this review in case it fell through the cracks! |
vbabanin
requested review from
a team and
rozza
and removed request for
a team and
vbabanin
rozza
requested changes
Sep 9, 2024
| .append("location", "New York City") | ||
| .append("timestamp", new Date(1727841600000L)); | ||
|
|
||
| collection.insertMany(Arrays.asList(temperature1, temperature2)); |
Member
There was a problem hiding this comment.
Need to subscribe to the publisher for the insert to happen.
Suggested change
| collection.insertMany(Arrays.asList(temperature1, temperature2)); | |
| Publisher<InsertManyResult> insertPublisher = collection.insertMany(Arrays.asList(temperature1, temperature2)); | |
| Mono.from(insertPublisher).block(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-42297
Staging -
Self-Review Checklist