Skip to content

Conversation

@rustagir
Copy link
Contributor

@rustagir rustagir commented Apr 3, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-48679

Staging Links

TLS page

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • [] Are the facets and meta keywords accurate?

@netlify
Copy link

netlify bot commented Apr 3, 2025

Deploy Preview for docs-java-rs ready!

Name Link
🔨 Latest commit 4c837f3
🔍 Latest deploy log https://app.netlify.com/sites/docs-java-rs/deploys/6807a0dbe0969b00084b8cca
😎 Deploy Preview https://deploy-preview-124--docs-java-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@katcharov katcharov requested a review from vbabanin April 8, 2025 14:52
Copy link
Member

@vbabanin vbabanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The terminology of asynchronous I/O is fine here since it reflects how Netty handles I/O in practice, even if it's not strictly OS-level async I/O like io_uring or IOCP.

@rustagir rustagir force-pushed the DOCSP-48679-netty-use branch from 54381b3 to 480559b Compare April 22, 2025 13:35
Copy link
Collaborator

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ one small fix!


.. tip:: Prefer Netty for Asynchronous Apps

We recommend using Netty for asychronous applications, as it supports
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style guide - as

Suggested change
We recommend using Netty for asychronous applications, as it supports
We recommend using Netty for asychronous applications because it supports

@rustagir rustagir merged commit 2f0b2ea into mongodb:main Apr 22, 2025
6 checks passed
rustagir added a commit that referenced this pull request Apr 22, 2025
rustagir added a commit that referenced this pull request Apr 22, 2025
rustagir added a commit that referenced this pull request Apr 22, 2025
rustagir added a commit that referenced this pull request Apr 22, 2025
(cherry picked from commit 2f0b2ea)
(cherry picked from commit 39ea353)
rustagir added a commit that referenced this pull request Apr 22, 2025
(cherry picked from commit 2f0b2ea)
(cherry picked from commit 39ea353)
(cherry picked from commit 17f8f62)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants