Skip to content

fix: don't log tool args #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: don't log tool args #296

wants to merge 1 commit into from

Conversation

nirinchev
Copy link
Collaborator

No description provided.

@Copilot Copilot AI review requested due to automatic review settings June 13, 2025 00:49
@nirinchev nirinchev requested a review from a team as a code owner June 13, 2025 00:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes logging of tool arguments to prevent sensitive data exposure.

  • Eliminates JSON.stringify of arguments in debug logs.
  • Updates log message to a generic format without args.
Comments suppressed due to low confidence (2)

src/tools/tool.ts:74

  • Add a unit test to verify that the debug log no longer includes tool arguments and aligns with the updated message format.
logger.debug(LogId.toolExecute, "tool", `Executing tool ${this.name}`);

src/tools/tool.ts:74

  • [nitpick] Consider adopting structured logging by passing this.name and, if needed, redacted args as separate properties to maintain queryable context without exposing raw data.
logger.debug(LogId.toolExecute, "tool", `Executing tool ${this.name}`);

Copy link
Collaborator

@fmenezes fmenezes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants