feat: Yarn PnP support #370
Conversation
| const targetRoot = rootDir || process.cwd(); | ||
| const nodeModulesPath = join(targetRoot, 'node_modules'); | ||
| if (!existsSync(nodeModulesPath)) { | ||
| mkdirSync(nodeModulesPath, { recursive: true }); | ||
| } | ||
| cachedNodeModulesDir = nodeModulesPath; | ||
| return cachedNodeModulesDir; |
There was a problem hiding this comment.
We are using vite project's root instead of traversing for existing folder because pnp doesn't generate node_modules and this seems more natural
There was a problem hiding this comment.
I see, I'm not sure if this is working on monorepo projects. cc @Xeikim you added this fix long time ago for monorepos.
There was a problem hiding this comment.
The original problem was that rootDir find traversal was using process.cwd not the actual vite project's root
We are still using vite's project rootDir (fixed by #256) but only omitting the traversal part - so it seems fine to me.
gioboa
left a comment
gioboa
left a comment
There was a problem hiding this comment.
Thanks for your contribution @ha1fstack
Unfortunately, in these days I'm quite busy and I can't review the PR as fast as I usually do.
I'm going to look at it in the next days.
2 participants
closes #155
Problem
Yarn PnP can not resolve arbitary qualified resolutions (or packages) whose are not declared explicitly.
However this plugin relies on on-the-fly generated __mf__virtual package inside physical node_modules folder - so it was not compatible
Tries
I first tried to use Vite's virtual module (in-memory) instead of real fs. But it did not work well since this plugin seems to be relying on (the intend is not documented so this is a guess) Vite's dependency pre-bundling - but virtual modules cannot be pre-bundled.
Solution
The root cause was not fs, so I focused on the qualified / unqualified resolution part. Instead of making the generated code as a package (with package.json and importing it with name), using unqualified resolution (real path) + creating alias to that path to keep things simple solved the issue.
Also fixed the problematic searchPackageVersion util too since the packages needs to be resolved from the host package (the service) root not the vite-mf's package root.