Open
Conversation
davidkoski
reviewed
Feb 23, 2026
| scale: Float, | ||
| offset: Int, | ||
| freqs: MLXArray? = nil, | ||
| stream: StreamOrDevice = .default |
Collaborator
There was a problem hiding this comment.
Do both of these files build on all platforms? I think maybe they don't on CPU only linux?
Just thinking out loud here:
- should we use something like
#if canImport(Metal)to select which file we use? - if both build, I wonder if we should switch on
streamto route to the correct backend? Then a GPU use could run the CPU implementation if they wanted.
davidkoski
reviewed
Feb 23, 2026
Comment on lines
1396
to
1397
| // note: this gives a warning but it does in fact do something | ||
| // in the case where this is e.g. ParameterInfo<MLXArray?> |
Collaborator
There was a problem hiding this comment.
If this works then I think this comment could just indicate which case it was (remove the part about the warning).
We have a test for it:
func testOptionInfos() {
class Layer1: Module {
@ParameterInfo var x: MLXArray?
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fills the gap of MLXNN and MLXFast on Linux (CPU mode)
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes