Skip to content

Fix race condition during the tracing phase of automatic differentiation (vjp, value_and_grad) #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidkoski merged 2 commits into from
Jan 21, 2026
Merged

Fix race condition during the tracing phase of automatic differentiation (vjp, value_and_grad) #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c6fd18
Fix race condition during the tracing phase of automatic differentiat…
aleroot Jan 16, 2026
5903477
Address pull request comments and use global evalLock
aleroot Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Source/MLX/Transforms+Internal.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ private func valueAndGradient(

var r0 = mlx_vector_array_new()
var r1 = mlx_vector_array_new()
mlx_closure_value_and_grad_apply(&r0, &r1, valueAndGrad, input_vector)

_ = evalLock.withLock {
mlx_closure_value_and_grad_apply(&r0, &r1, valueAndGrad, input_vector)
}

defer { mlx_vector_array_free(r0) }
defer { mlx_vector_array_free(r1) }
Expand Down
12 changes: 10 additions & 2 deletions Source/MLX/Transforms.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@ public func jvp(
var r1 = mlx_vector_array_new()

let closure = new_mlx_closure(f)
mlx_jvp(&r0, &r1, closure, primals_mlx, tangents_mlx)

_ = evalLock.withLock {
mlx_jvp(&r0, &r1, closure, primals_mlx, tangents_mlx)
}

mlx_closure_free(closure)

defer { mlx_vector_array_free(r0) }
Expand Down Expand Up @@ -60,7 +64,11 @@ public func vjp(
var r1 = mlx_vector_array_new()

let closure = new_mlx_closure(f)
mlx_vjp(&r0, &r1, closure, primals_mlx, cotangents_mlx)

_ = evalLock.withLock {
mlx_vjp(&r0, &r1, closure, primals_mlx, cotangents_mlx)
}

mlx_closure_free(closure)

defer { mlx_vector_array_free(r0) }
Expand Down