Handle stringified JSON tool call arguments#172
Open
kuosuko wants to merge 1 commit intoml-explore:mainfrom
Open
Handle stringified JSON tool call arguments#172kuosuko wants to merge 1 commit intoml-explore:mainfrom
kuosuko wants to merge 1 commit intoml-explore:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #169.
Problem
JSONToolCallParserassumesargumentsis always a JSON object, but some models emit it as a JSON-encoded string instead.That means payloads like this fail to parse today:
{"name":"get_weather","arguments":"{\"location\":\"Paris\"}"}As a result, Swift drops the tool call entirely.
Fix
Normalize the outer JSON payload before decoding
ToolCall.Function:JSONSerializationargumentsis a string, parse that string as JSONargumentswith the parsed valueJSONDecoderThis preserves the current behavior for object-shaped arguments while adding compatibility for stringified arguments.
Testing
swift test --filter ToolTestsI also verified locally with Granite tool calling that the original parser emitted no parsed tool call while the patched parser successfully emitted
get_weather(location: "Tokyo", unit: "celsius").