refactor: use time.perf_counter() for duration measurements#848
Open
m92y wants to merge 1 commit intoml-explore:mainfrom
Open
refactor: use time.perf_counter() for duration measurements#848m92y wants to merge 1 commit intoml-explore:mainfrom
m92y wants to merge 1 commit intoml-explore:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor to use
time.perf_counter()instead oftime.time()for duration measurements.Files modified:
mlx_lm/cache_prompt.pymlx_lm/perplexity.pymlx_lm/quant/dwa.pymlx_lm/server.pyRationale:
time.time()can be affected by system clock updates (NTP sync), whereastime.perf_counter()is a monotonic clock that never goes backward.mlx-lmwith the timing approach already adopted in the core MLX library (see [ml-explore/mlx#2943](refactor: use time.perf_counter for consistent and accurate benchmarking mlx#2943)).Note:
time.time()is intentionally preserved inserver.pyline 244 (self.created = int(time.time())) as this generates an epoch timestamp for API responses, not a duration measurement.