moved more activation functions to activations module#774
Open
Goekdeniz-Guelmez wants to merge 12 commits intoml-explore:mainfrom
Open
moved more activation functions to activations module#774Goekdeniz-Guelmez wants to merge 12 commits intoml-explore:mainfrom
Goekdeniz-Guelmez wants to merge 12 commits intoml-explore:mainfrom
Conversation
Goekdeniz-Guelmez
changed the title
awni
reviewed
Jan 26, 2026
Contributor
Author
|
@awni, sorry that it took so long but this should be cleanly mergable now |
angeloskath
requested changes
Feb 6, 2026
Member
angeloskath
left a comment
angeloskath
left a comment
There was a problem hiding this comment.
Looks good, I think the SwiGLU should be renamed to match what it actually does and then we can merge.
Contributor
Author
|
@angeloskath fixed, also moved the base SwiGlu in switch_layers to activations as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found some more activation functions that should be moved as well