Add EngGPT MoE model support#1199
Open
robertobissanti wants to merge 1 commit intoml-explore:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds initial support for the
enggpt_moearchitecture used byengineering-group/EngGPT2-16B-A3B.The model is a decoder-only MoE language model with:
head_dim = 128rope_theta = 1000000.0lm_headThe implementation is based on the existing Mixtral/SwitchGLU infrastructure, adapted to match the EngGPT MoE checkpoint structure and routing logic.
Motivation
The EngGPT2-16B-A3B model cannot currently be loaded or converted with
mlx-lmbecause itsconfig.jsondeclares: