-
Notifications
You must be signed in to change notification settings - Fork 194
More Mixin Fixes #2471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Mixin Fixes #2471
Conversation
Adding our elements one by one lets some of them get frozen above the normal suggestions. Instead, we should add them all in a batch.
src/main/kotlin/platform/mixin/completion/InjectionPointTypedHandlerDelegate.kt
Outdated
Show resolved
Hide resolved
The |
As in I should inform them / make a PR there, or try to maintain bin compat? |
Trying to maintain binary compat is the best, but not at the expense of keeping our own codebase maintainable. We don't have many API consumers so we can get away with breaking binary compat as long as we inform the major ones (I can only think of MixinSquared tbh) |
I can inform them yeah, they don't have any injection points anyway so should be minor |
258c2ee
to
3881882
Compare
This includes several related things like: - Rework `CollectVisitor`s to work with `Sequence`s rather than having a special case for only wanting the first result - Rework `CollectResultFilter`s to filter based on the whole sequence (this is needed to support `:LAST`) - Offer proper completion options for specifiers in the right context - Fix `At#value` completions disappearing after typing `:`
3881882
to
a9c3fab
Compare
The MixinSquared plugin needs no changes. |
Fixes mixin shadow autocomplete results often being prioritized over regular java ones
Also adds much better support for injection point specifiers.
The latter required some decently big reworks to the
CollectVisitor
system.During that I greatly improved the (previously nonexistent due to bugs) message about which filters were responsible for the failure.
Happy to debate any of the refactors if you disagree with them.
Also as a side note, I keep my commit history clean, so it would be preferable for my PRs not to be squashed.