[Backport 2.6] fix: pass address to GrpcHandler in ConnectionManager strategies (#3321)#3323
Merged
sre-ci-robot merged 1 commit intomilvus-io:2.6from Mar 20, 2026
Conversation
…strategies (milvus-io#3321) fix: pass address to GrpcHandler in ConnectionManager strategies RegularStrategy and AsyncRegularStrategy did not pass config.address to GrpcHandler/AsyncGrpcHandler, causing GrpcHandler.__get_address to parse unix-socket URIs returned by milvus-lite and produce an empty netloc → empty gRPC target (dns:///) → connection hang. See also: milvus-io#3314, milvus-io#3317, milvus-io#3321 Signed-off-by: xuan.yang <xuan.yang@zilliz.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.6 #3323 +/- ##
=======================================
Coverage 89.93% 89.93%
=======================================
Files 64 64
Lines 13348 13348
=======================================
Hits 12004 12004
Misses 1344 1344 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Mar 19, 2026
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: pass address to GrpcHandler in ConnectionManager strategies
RegularStrategy and AsyncRegularStrategy did not pass
config.address to GrpcHandler/AsyncGrpcHandler, causing
GrpcHandler.__get_address to parse unix-socket URIs returned
by milvus-lite and produce an empty netloc → empty gRPC target
(dns:///) → connection hang.
See also: #3314, #3317, #3321
Signed-off-by: xuan.yang xuan.yang@zilliz.com