-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat: support grpc tokenizer #41994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: support grpc tokenizer #41994
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sangheee The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sangheee Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
3cffa99
to
f78f966
Compare
@sangheee E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project check has failed because the head coverage (73.10%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #41994 +/- ##
==========================================
+ Coverage 73.03% 73.10% +0.06%
==========================================
Files 335 335
Lines 30700 30727 +27
==========================================
+ Hits 22423 22464 +41
+ Misses 8277 8263 -14
🚀 New features to boost your workflow:
|
f78f966
to
d21db6c
Compare
@sangheee E2e jenkins job failed, comment |
d21db6c
to
6a9b800
Compare
@sangheee go-sdk check failed, comment |
1 similar comment
@sangheee go-sdk check failed, comment |
Signed-off-by: park.sanghee <[email protected]>
6a9b800
to
6e12c46
Compare
Signed-off-by: park.sanghee <[email protected]>
@sangheee go-sdk check failed, comment |
@sangheee cpp-unit-test check failed, comment |
@sangheee E2e jenkins job failed, comment |
relate: #41035
This PR adds support for a gRPC-based tokenizer.
tantivi-binding
.milvus.proto.tokenizer.rs
.I'm not very experienced with Rust, so there might be parts of the code that could be improved.
I’d appreciate any suggestions or improvements.