Skip to content

feature: support multi analyzer for restful(#41968) #41969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MrPresent-Han
Copy link
Contributor

@MrPresent-Han MrPresent-Han commented May 21, 2025

related: #41968
pr: #41970

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrPresent-Han
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 21, 2025
@mergify mergify bot added the dco-passed DCO check passed. label May 21, 2025
Copy link
Contributor

mergify bot commented May 21, 2025

@MrPresent-Han Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

mergify bot commented May 21, 2025

@MrPresent-Han

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link
Contributor

mergify bot commented May 21, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 80.60%. Comparing base (0e75e66) to head (451c232).
Report is 18 commits behind head on 2.5.

Files with missing lines Patch % Lines
...nternal/distributed/proxy/httpserver/handler_v2.go 0.00% 11 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (7.69%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #41969      +/-   ##
==========================================
- Coverage   80.65%   80.60%   -0.05%     
==========================================
  Files        1427     1427              
  Lines      205136   205615     +479     
==========================================
+ Hits       165456   165744     +288     
- Misses      33877    34051     +174     
- Partials     5803     5820      +17     
Components Coverage Δ
Client 79.42% <ø> (ø)
Core 70.61% <ø> (-0.07%) ⬇️
Go 82.59% <7.69%> (-0.04%) ⬇️
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/request_v2.go 83.09% <ø> (ø)
...rnal/util/function/multi_analyzer_bm25_function.go 64.90% <100.00%> (ø)
...nternal/distributed/proxy/httpserver/handler_v2.go 92.04% <0.00%> (-0.48%) ⬇️

... and 64 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrPresent-Han
Copy link
Contributor Author

rerun ut

@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e

@MrPresent-Han
Copy link
Contributor Author

rerun ut

Copy link
Contributor

mergify bot commented May 22, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 22, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the support-mulit-analyzer-resful-2.5 branch from 2206c33 to 8107d05 Compare May 26, 2025 13:02
Copy link
Contributor

mergify bot commented May 26, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. do-not-merge/invalid-pr-format size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants