Skip to content

Conversation

@Fleezesd
Copy link

What kind of this pr?

feat: Optimize CalcFloatDistance Function to Limit Concurrent Goroutines

Detailed Description

This PR introduces an enhancement to the CalcFloatDistance function by limiting the number of concurrent goroutines. The aim is to prevent excessive resource consumption and ensure efficient resource utilization. The changes include:

Utilizing runtime.NumCPU() * 2 to dynamically set the maximum number of concurrent goroutines, leveraging multi-core CPU capabilities.
Implementing a buffered channel guard to control the number of active goroutines.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Fleezesd
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Contributor

Welcome @Fleezesd! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jul 16, 2024
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jul 16, 2024
@mergify
Copy link
Contributor

mergify bot commented Jul 16, 2024

@Fleezesd Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the kind/feature Issues related to feature request from users label Jul 16, 2024
@mergify
Copy link
Contributor

mergify bot commented Jul 16, 2024

@Fleezesd Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/missing-related-issue kind/feature Issues related to feature request from users needs-dco DCO is missing in this pull request. size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants