feat: add function_name to AlterCollectionSchema DropRequest#583
Open
sijie-ni-0214 wants to merge 1 commit intomilvus-io:masterfrom
Open
feat: add function_name to AlterCollectionSchema DropRequest#583sijie-ni-0214 wants to merge 1 commit intomilvus-io:masterfrom
sijie-ni-0214 wants to merge 1 commit intomilvus-io:masterfrom
Conversation
Extend DropRequest oneof identifier with function_name field, enabling drop function with cascade deletion of output fields. Signed-off-by: sijie-ni-0214 <sijie.ni@zilliz.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sijie-ni-0214 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AlterCollectionSchemaRequest.DropRequestoneof identifier withfunction_namefield (tag 3)field_identifiertoidentifierto reflect the broader scopeThis enables dropping functions (with cascade deletion of output fields and indexes) through the existing
AlterCollectionSchemaRPC.Related issue: milvus-io/milvus#48983