Skip to content

fix(folly): add libaio to system_libs for Linux#97

Open
jiaqizho wants to merge 1 commit into
milvus-io:add-folly-2024.08.12.00-sse42from
jiaqizho:fix/folly-add-libaio-system-lib
Open

fix(folly): add libaio to system_libs for Linux#97
jiaqizho wants to merge 1 commit into
milvus-io:add-folly-2024.08.12.00-sse42from
jiaqizho:fix/folly-add-libaio-system-lib

Conversation

@jiaqizho

Copy link
Copy Markdown

Folly's AsyncIO uses libaio functions (io_submit, io_getevents, io_queue_init, io_queue_release), but libaio was not declared as a system library dependency in package_info(). This causes undefined reference errors at link time for consumers like milvus-storage.

Add "aio" to system_libs under the existing Linux-only condition for both the legacy recipe (folly/all) and the v2024 recipe (folly/v2024).

@jiaqizho

Copy link
Copy Markdown
Author

@xiaofan-luan PTAL

@yhmo

yhmo commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

@jiaqizho
We will migrate the master branch of this repo to conan 2.x, please convert this pr to the "conan-1.x" branch: https://github.com/milvus-io/conanfiles/tree/conan-1.x
Now the "conan-1.x" branch is fully consistent with the master branch.
Once this pr is merged, the master branch will be used for conan2.x-only publish.
It is a part of this job: milvus-io/milvus#47425 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants