Add optional fieldsets for when creating new model from EditableArrayCard#577
Open
ekatsuta wants to merge 3 commits intoantd3-with-updatesfrom
Open
Add optional fieldsets for when creating new model from EditableArrayCard#577ekatsuta wants to merge 3 commits intoantd3-with-updatesfrom
ekatsuta wants to merge 3 commits intoantd3-with-updatesfrom
Conversation
ellenshin
approved these changes
Sep 7, 2023
added 2 commits
September 7, 2023 17:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added this optional props (
onCreateFieldsets) to theEditableArrayCardcomponent so that we can conditionally render different fieldsets when user is creating a new objects vs. editing an existing object. (In this example, service team members in CoOp could create a new investment and need to access all fields available on the form, but only be able to edit the "Charge Off Date" on existing investments)Related Coop-client PR: https://github.com/mighty-justice/coop-client/pull/1200
Jira: https://thatsmighty.atlassian.net/browse/PROD-2137
Test on Storybook
Test in CoOp