Support ACPI NVDA PNP parsing for GPU detection - #1290
Open
fangyangci wants to merge 1 commit into
Open
Conversation
fangyangci
marked this pull request as ready for review
August 7, 2026 02:12
xieofxie
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add support for ACPI\NVDA#### style PNP IDs in hardware detection
map ACPI NVDA IDs to NVIDIA vendor id 0x10DE and parse the 4-digit device id as hex
keep existing PCI VEN_/DEV_ and Qualcomm parsing branches unchanged
add unit test coverage for ACPI\NVDA200A\0 parsing
Why
Some ARM devices expose NVIDIA adapters through ACPI IDs instead of PCI VEN_/DEV_ tokens. Without this handling, device parsing can fail and downstream provider compatibility may be marked incorrectly.
Validation
python -m pytest tests/unit/sysinfo/test_hardware.py -q
result: 25 passed