Classify Agent Host Copilot startup failures - #329714
Draft
roblourens (roblourens) wants to merge 1 commit into
Draft
Classify Agent Host Copilot startup failures#329714roblourens (roblourens) wants to merge 1 commit into
roblourens (roblourens) wants to merge 1 commit into
Conversation
Add bounded startup cause, resource, and exit-code telemetry, including SDK timeouts and permission failures.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds bounded telemetry diagnostics for Agent Host Copilot startup failures.
Changes:
- Classifies startup causes, resources, and safe exit codes.
- Recognizes SDK startup timeouts and permission failures.
- Adds focused telemetry tests.
Show a summary per file
| File | Description |
|---|---|
copilotFailureTelemetry.ts |
Adds startup-failure classification and telemetry fields. |
copilotFailureTelemetry.test.ts |
Tests timeout lifecycle classification. |
copilotAgent.test.ts |
Tests bounded startup diagnostics. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
| if (normalizedMessage.includes('runtime.node') || normalizedMessage.includes('runtime.win32') || normalizedMessage.includes('native addon "runtime"')) { | ||
| return 'runtime'; | ||
| } | ||
| if (normalizedMessage.includes('sandbox') || normalizedMessage.includes('mxc') || normalizedMessage.includes('wxc')) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds bounded diagnostics to the existing Agent Host Copilot client-failure event after startup failures were observed to strand affected machines before any successful user turn.
The new fields classify:
runtime,cliNative,conpty,sandbox, orother);This also brings SDK startup timeouts into the existing
startupFailedclassification and recognizesEACCES/EPERMspawn errors as permission failures.The fields avoid relying on raw exception text for aggregate reliability analysis. Retry/backoff behavior is intentionally left to a separate change because it affects product behavior.
Related: #329713
Validation
npm run transpile-client./scripts/test.sh --run src/vs/platform/agentHost/test/node/copilotFailureTelemetry.test.ts --run src/vs/platform/agentHost/test/node/copilotAgent.test.ts --grep 'CopilotFailureTelemetry|reports .*Copilot client startup failure'git diff --check(Written by Copilot)