Skip to content

Fix accessibility: Add proper ARIA attributes to Saved Connection items #19597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix accessibility: Add proper ARIA attributes to Saved Connection items #19597

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
024b332
Initial plan for issue
Copilot Jun 13, 2025
97d23a3
Add accessibility attributes to ConnectionCard components
Copilot Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 45 additions & 26 deletions src/reactviews/pages/ConnectionDialog/connectionsListContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
makeStyles,
tokens,
} from "@fluentui/react-components";
import { MouseEventHandler, useContext, useEffect, useState } from "react";
import { KeyboardEventHandler, MouseEventHandler, useContext, useEffect, useState } from "react";

import { ConnectionDialogContext } from "./connectionDialogStateProvider";
import { IConnectionDialogProfile } from "../../../sharedInterfaces/connectionDialog";
Expand Down Expand Up @@ -81,7 +81,10 @@ export const ConnectionsListContainer = () => {
onClick={context.refreshConnectionsList}
/>
</div>
<div className={styles.main}>
<div
className={styles.main}
role="list"
aria-label={locConstants.connectionDialog.savedConnections}>
{// state may not be initialized yet due to async loading of context
context.state?.savedConnections.map((connection, index) => {
return (
Expand Down Expand Up @@ -110,7 +113,7 @@ export const ConnectionsListContainer = () => {
onClick={context.refreshConnectionsList}
/>
</div>
<Tree>
<Tree role="list" aria-label={locConstants.connectionDialog.recentConnections}>
{// state may not be initialized yet due to async loading of context
context.state?.recentConnections.map((connection, index) => {
return (
Expand Down Expand Up @@ -173,29 +176,45 @@ export const ConnectionCard = ({
return undefined;
}

const handleClick = () => {
context.loadConnection(connection);
};

const handleKeyDown: KeyboardEventHandler = (event) => {
if (event.key === "Enter" || event.key === " ") {
event.preventDefault();
handleClick();
}
};

return (
<Card
className={styles.connectionContainer}
appearance="subtle"
onClick={() => {
context.loadConnection(connection);
}}>
<CardHeader
image={<ServerRegular fontSize={20} />}
header={displayName}
action={
actionButton && (
<div className={buttonContainer}>
<Button
icon={actionButton.icon}
appearance="subtle"
onClick={actionButton.onClick}
title={actionButton.tooltip}
/>
</div>
)
}
/>
</Card>
<div role="listitem">
<Card
className={styles.connectionContainer}
appearance="subtle"
onClick={handleClick}
role="button"
tabIndex={0}
aria-label={`Connect to ${displayName}`}
onKeyDown={handleKeyDown}>
<CardHeader
image={<ServerRegular fontSize={20} />}
header={displayName}
action={
actionButton && (
<div className={buttonContainer}>
<Button
icon={actionButton.icon}
appearance="subtle"
onClick={actionButton.onClick}
title={actionButton.tooltip}
aria-label={actionButton.tooltip}
/>
</div>
)
}
/>
</Card>
</div>
);
};