Reset flaggedForDeletion property after query editor close & reopen #19407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cssuh
requested review from
kburtram,
aasimkhan30,
caohai,
laurenastrid1,
lewis-sanchez and
Benjin
as code owners
cssuh
changed the title
PR Changes
|
kburtram
reviewed
May 12, 2025
| @@ -91,6 +93,13 @@ export default class QueryRunner { | |||
| this._vscodeWrapper = new VscodeWrapper(); | |||
| } | |||
|
|
|||
| // Setup Logger | |||
|
|
|||
| let channel = this._vscodeWrapper.createOutputChannel( | |||
There was a problem hiding this comment.
do we need a separate logging channel? I'm wonder if it's best practice to create new output channels per feature area?
There was a problem hiding this comment.
I was just following the convention used elsewhere in the extension, should we consolidate all the logs into one channel?
There was a problem hiding this comment.
We should be using vscodeWrapper.outputChannel, which will reuse the existing MSSQL one. Also, ideally adding a logging prefix to make logs easier to filter through: Logger.create(channel, "Querys") or maybe "QueryRunner"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we close a query editor, the associated query runner gets flagged for deletion, with a timer of 30 minutes. This flag does not get reset if we re-open the same query editor and run a query, which can lead to deletion of the query runner in the middle of a long-running query (due to the 30 minute timer) and can put the query editor in a bad state.
I have added a conditional which will reset the
flaggedForDeletionproperty if we are re-using an existing query runner. I also added some additional logging to help with debugging in the future.Fixes #18837