Surface external index state in status item too

[mjbvz]

For microsoft/vscode#290782

[dmitrivMS]

@mjbvz CI is unhappy...

[Copilot]

Pull request overview

Surfaces external ingest (non-code-search) indexing state in the remote indexing status so the chat status item can reflect external ingest progress.

Changes:

• Added external ingest status shape + state-change eventing to ExternalIngestIndex.
• Extended CodeSearchRemoteIndexState to include externalIngestState and wired it through getRemoteIndexState().
• Updated the workspace indexing status item to show “building” when external ingest is building.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
src/platform/workspaceChunkSearch/node/codeSearch/externalIngestIndex.ts	Adds ExternalIngestStatus, state tracking, and an event to notify UI/state consumers about progress.
src/platform/workspaceChunkSearch/node/codeSearch/codeSearchChunkSearch.ts	Plumbs external ingest state into getRemoteIndexState() and forwards external ingest state changes into the existing index-state event.
src/extension/workspaceChunkSearch/vscode-node/workspaceIndexingStatus.ts	Displays external ingest “building” progress in the chat status item.

Comments suppressed due to low confidence (1)

src/platform/workspaceChunkSearch/node/codeSearch/externalIngestIndex.ts:106

• getState() reports CodeSearchRepoStatus.Ready whenever _currentIngestOperation.completed is true, even if the ingest operation failed (checkpoint not updated) and _currentIngestOperation is never cleared. This can make the UI show “Ready” after an error. Consider tracking the final Result/success flag (or clearing _currentIngestOperation on completion) and deriving the post-completion status from the checkpoint / last result instead of always returning Ready.

	public getState(): ExternalIngestStatus {
		if (this._currentIngestOperation) {
			if (this._currentIngestOperation.completed) {
				return {
					status: CodeSearchRepoStatus.Ready,
					progressMessage: undefined,
				};
			} else {
				return {
					status: CodeSearchRepoStatus.BuildingIndex,
					progressMessage: this._currentIngestOperation.progressMessage,
				};
			}

[Copilot]

operation is created with promise: undefined! and later mutated via a cast to bypass the readonly promise field. This weakens type safety and makes the state tracking harder to reason about. Consider restructuring so the promise field is assigned normally (e.g., make it non-readonly or build the object after updatePromise is created) to avoid the non-null assertion and cast.

[Copilot]

CodeSearchRemoteIndexState.status is a string union ('disabled' | 'initializing' | 'loaded'), but this branch returns status: '', which is not a valid value and should fail type-checking. If “force external ingest only” should still be treated as a loaded/initializing remote-index state, return one of the existing union values (and include externalIngestState as needed).

Suggested change

	status: '',
	status: 'loaded',

[Copilot]

This external ingest “BuildingIndex” UI check runs before verifying that all repos are Ready (and before the checks for CheckingStatus / BuildingIndex on repos). As written, it can surface external ingest progress even while one or more repos are still building/checking, which can mask the more relevant repo status. Consider gating this on repos.every(...Ready) or moving it after the repo-status checks.