[vsgqt] New port #47899
Open
[vsgqt] New port #47899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
reviewed
Oct 23, 2025
| v8:x64-windows-static=fail | ||
| v8:x64-windows=fail | ||
| v8:x86-windows=fail | ||
| # https://github.com/vsg-dev/vsgQt/pull/53 |
There was a problem hiding this comment.
This means that it isn't a problem with our build lab and is a problem with the port, so it should probably be a "supports" right?
There was a problem hiding this comment.
Well, I expect upstream to merge the PR and CI to remind us of the changed result when the port is updated.
I dislike the chance of the port being updated with the supports clause preventing test in CI.
BillyONeal
reviewed
Oct 23, 2025
BillyONeal
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://repology.org/project/vsgqt/versions
CC @gwaldron (related: #46945)