Skip to content

Conversation

hanjingo
Copy link

@hanjingo hanjingo commented Oct 20, 2025

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please complete the new port checklist I uncommented in the PR description. In particular I think the name likely needs to be hanjingo-high-jump because high-jump is neither in repology, nor does that repo appear in the first page of search results for "high jump c++" for me.

@BillyONeal BillyONeal added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 20, 2025
@BillyONeal BillyONeal changed the title [high-jump] Add/update vcpkg port for high-jump (header-only): usage, portfile, v… [high-jump] New Por Oct 20, 2025
@BillyONeal BillyONeal changed the title [high-jump] New Por [high-jump] New Port Oct 20, 2025
@BillyONeal BillyONeal marked this pull request as draft October 20, 2025 12:41
@hanjingo
Copy link
Author

Please complete the new port checklist I uncommented in the PR description. In particular I think the name likely needs to be hanjingo-high-jump because high-jump is neither in repology, nor does that repo appear in the first page of search results for "high jump c++" for me.

Thank you for your suggestion. I checked on https://repology.org/ and did not find any existing project named "high-jump". Therefore, I would prefer to keep the current port name "high-jump".

@hanjingo hanjingo marked this pull request as ready for review October 22, 2025 00:47
@hanjingo hanjingo requested a review from BillyONeal October 22, 2025 00:51
@BillyONeal
Copy link
Member

Thank you for your suggestion. I checked on https://repology.org/ and did not find any existing project named "high-jump".

That is exactly the problem. By default we don't put 'pretty names' on things because we can always add the pretty name later, but once the pretty name is 'assigned' we can never change it ever again.

Note that this isn't about the name of your library. The vcpkg port named hanjingo-high-jump can install a library named just high-jump.

@hanjingo
Copy link
Author

Thank you for your suggestion. I checked on https://repology.org/ and did not find any existing project named "high-jump".

That is exactly the problem. By default we don't put 'pretty names' on things because we can always add the pretty name later, but once the pretty name is 'assigned' we can never change it ever again.

Note that this isn't about the name of your library. The vcpkg port named hanjingo-high-jump can install a library named just high-jump.

Repo renamed to hanjingo/hanjingo-high-jump and portfile updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants