-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[high-jump] New Port #47885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[high-jump] New Port #47885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please complete the new port checklist I uncommented in the PR description. In particular I think the name likely needs to be hanjingo-high-jump
because high-jump
is neither in repology, nor does that repo appear in the first page of search results for "high jump c++" for me.
… redundant debug cleanup, delete format.diff
Thank you for your suggestion. I checked on https://repology.org/ and did not find any existing project named "high-jump". Therefore, I would prefer to keep the current port name "high-jump". |
That is exactly the problem. By default we don't put 'pretty names' on things because we can always add the pretty name later, but once the pretty name is 'assigned' we can never change it ever again. Note that this isn't about the name of your library. The vcpkg port named |
Repo renamed to hanjingo/hanjingo-high-jump and portfile updated |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.